-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this approval for you after you decide how you feel about my suggestion :)
from: { | ||
option: "--from <account>", | ||
description: | ||
"Specify the account from which to make calls or send transactions." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's worth adding this word here:
"Specify the account from which to make calls or send transactions." | |
"Specify the default account from which to make calls or send transactions." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the default
word makes sense. Thanks for the suggestion, @gnidan.
Although actually we may want this PR to include the removal of |
We have the |
Hey @gnidan. I checked the commands in the |
Oh, interesting. Most commands do support this flag today... like |
I didn't know about that. Thanks @gnidan for letting me know about it. I think we should later on(in a separate PR) add the |
This PR adds
--from
option to truffle global command options list, which can be used to specify an account to make calls or send transactions. This is related to #5330, where it was discussed to be a separate PR.