This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a draft for the moment as I need to rework the history one more time. I just wanted to push something up that matches what I expect the final state will be so that I can start getting CI feedback. |
benjamincburns
force-pushed
the
revive-preserve
branch
from
August 18, 2022 05:29
d5a489e
to
2845dd7
Compare
This reverts commit 5bacf5a.
- update package names - .gitgnore node_modules - configure package.json and lerna.json - initial scripts for publishing - add missing dependencies - preserve - @truffle/error - @trufflesuite/typedoc-default-themes - preserve-fs - @types/tmp - pin troublesome dependency versions - typescript is pinned to 4.2.4 because that is the most current version that typedoc supports - ganache is pinned to "3.0.0-filecoin.3" because supsequent versions break preserve-to-{filecoin,ipfs} - @ganache/filecoin is also pinned to "0.1.2" because subsequent versions also break preserve-to-{filecoin,ipfs} - commit yarn.lock - install and configure lint-staged This is to use husky git hooks at the pre-commit lifecycle to lint and prettify changes following `lint-staged` [1] installation and setup guide - install prettier - install and configure eslint with .eslintrc - .gitignore .eslintcache - run `npx mrm@2 lint-staged` then tweek the tasks to run, that is, run prettier and eslint at pre-commit 1: https://github.com/okonet/lint-staged#installation-and-setup - add trace command for testing - add github action
- @truffle/[email protected] - @truffle/[email protected] - @truffle/[email protected] - @truffle/[email protected] - @truffle/[email protected]
This needed for truffle projects that uses the preserve infrastructure
- @truffle/[email protected] - @truffle/[email protected] - @truffle/[email protected] - @truffle/[email protected] - @truffle/[email protected]
benjamincburns
force-pushed
the
revive-preserve
branch
from
August 18, 2022 06:35
2845dd7
to
b0146f2
Compare
This is ready for review now, I think. I'll push a second PR that removes the |
- @types/node - @types/jest - typescript - typedoc - jest - ts-jest
benjamincburns
force-pushed
the
revive-preserve
branch
from
August 18, 2022 06:57
b0146f2
to
882ea34
Compare
cds-amal
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @benjamincburns. Looks good to me!
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings
@truffle/preserve
back into the project, but leaves the plugins in the trufflesuite/preserves repo. Attempts to preserve history where possible, although it gets a bit weird in places.Addresses #5452.