Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Revive @truffle/preserve #5455

Merged
merged 7 commits into from
Aug 19, 2022
Merged

Revive @truffle/preserve #5455

merged 7 commits into from
Aug 19, 2022

Conversation

benjamincburns
Copy link
Contributor

@benjamincburns benjamincburns commented Aug 18, 2022

Brings @truffle/preserve back into the project, but leaves the plugins in the trufflesuite/preserves repo. Attempts to preserve history where possible, although it gets a bit weird in places.

Addresses #5452.

@benjamincburns
Copy link
Contributor Author

This is a draft for the moment as I need to rework the history one more time. I just wanted to push something up that matches what I expect the final state will be so that I can start getting CI feedback.

benjamincburns and others added 6 commits August 18, 2022 18:32
- update package names
- .gitgnore node_modules
- configure package.json and lerna.json
- initial scripts for publishing
- add missing dependencies
  - preserve
    - @truffle/error
    - @trufflesuite/typedoc-default-themes
  - preserve-fs
    - @types/tmp
- pin troublesome dependency versions
  - typescript is pinned to 4.2.4 because that is the most current version that
    typedoc supports
  - ganache is pinned to "3.0.0-filecoin.3" because supsequent versions break
    preserve-to-{filecoin,ipfs}
  - @ganache/filecoin is also pinned to "0.1.2" because subsequent versions also
    break preserve-to-{filecoin,ipfs}
- commit yarn.lock
- install and configure lint-staged
  This is to use husky git hooks at the pre-commit lifecycle to lint and
  prettify changes following `lint-staged` [1] installation and setup guide

  - install prettier
  - install and configure eslint with .eslintrc
  - .gitignore .eslintcache
  - run `npx mrm@2 lint-staged` then tweek the tasks to run, that is, run
    prettier and eslint at pre-commit

  1: https://github.com/okonet/lint-staged#installation-and-setup
- add trace command for testing
- add github action
This needed for truffle projects that uses the preserve infrastructure
@benjamincburns
Copy link
Contributor Author

This is ready for review now, I think. I'll push a second PR that removes the spinnies dep in favor of @truffle/spinners, but otherwise that should be it 🤞

- @types/node
- @types/jest
- typescript
- typedoc
- jest
- ts-jest
Copy link
Member

@cds-amal cds-amal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @benjamincburns. Looks good to me!

@benjamincburns benjamincburns merged commit 0ed44cf into develop Aug 19, 2022
@benjamincburns benjamincburns mentioned this pull request Aug 25, 2022
@haltman-at haltman-at deleted the revive-preserve branch June 26, 2023 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants