This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Type opcodes table as const in @truffle/code-utils #5557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haltman-at
reviewed
Sep 21, 2022
packages/code-utils/src/opcodes.ts
Outdated
|
|
||
| export = (op: number) => (codes[op] ? codes[op] : "INVALID"); | ||
| export const parseOpcode = (op: number) => | ||
| codes[op in codes ? (op as keyof OpcodeTable) : 0xfe]; |
There was a problem hiding this comment.
Using 0xfe as a default before the lookup, rather than "INVALID" after, is pretty confusing. I think it would be better to do this the old way (not necessarily the same code, but at least doing the defaulting after), or, failing that, there should at least be a comment to explain this.
There was a problem hiding this comment.
Okee! Yeah I was on the fence. I'll switch it back.
As usual, this work is driven by some offhand hacking :) |
haltman-at
approved these changes
Sep 21, 2022
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't like how this was needlessly clobbering type information, so this PR modifies @truffle/code-utils to preserve
const-ness in its definition of the opcodes table.