This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Remove Arbitrum Rinkeby and Optimistic Kovan from Etherscan fetcher #5759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haltman-at
requested review from
gnidan,
benjamincburns,
cds-amal,
fainashalts,
lsqproduction,
eggplantzzz,
sukanyaparashar and
cliffoo
|
LGTM but failing tests for some reason! |
|
Oh, duh! It's failing tests because we had explicit tests for that network. Guess I'd better remove those. |
haltman-at
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Etherscan has removed support for Arbitrum Rinkeby; the old URL
testnet.arbiscan.iois still there, sure, but now it's just a duplicate ofgoerli.arbiscan.io. So, I'm removing support from this network from the Etherscan fetcher. (Note that it's still supported by the Sourcify fetcher, since while Sourcify will disable new networks and stop letting you verify on them, it doesn't remove access to the already-verified contracts.)Edit: Looks like Optimistic Kovan is gone too, removed that too. (Along with the appropriate tests.)
Boba Rinkeby is also gone and replaced by Boba Goerli, but I'm going to save handling that for a separate PR as I need more information there.