This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
add a warning when unable to save the solidity compiler to disk instead of throwing #5934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cds-amal
previously approved these changes
Feb 24, 2023
cds-amal
reviewed
Feb 25, 2023
There was a problem hiding this comment.
Nice quality of life change, @eggplantzzz. I have some small nits and a question: did you consider wrapping Cache.add() in a try-catch since it's the logic that does the writing?
packages/compile-solidity/src/compilerSupplier/loadingStrategies/VersionRange.ts
Show resolved
Hide resolved
packages/compile-solidity/src/compilerSupplier/loadingStrategies/VersionRange.ts
Outdated
Show resolved
Hide resolved
…es/VersionRange.ts Co-authored-by: cds-amal <[email protected]>
cds-amal
approved these changes
Feb 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when Truffle fails to save the Solidity compiler to the cache directory, it will throw an error. This PR changes this behavior so that it displays a warning to the user and continues on with the rest of the compilation flow.