This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Stop serializing HH config data we don't need #5938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
As raised by @emilyJLin95, this PR fixes a problem where
hre.config
now contains non-serializable data. Since @truffle/from-hardhat needs only a small portion of the data inhre.config
, this PR takes the approach to pre-process it, whittling it down to just what we need. This prevents serialization issues that may arise.Testing instructions
In repo root:
In a new directory for a fresh HH project:
In that node repl that just started:
Observe that it does not break.
Oh, and you'll need the latest Node.js if you want that
await
to work.Documentation
doc-change-required
label to this PR if documentation updates are required.Breaking changes and new features
breaking-change
andnew-feature
labels for the appropriate packages.