This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update Ganache to 7.9.1; turn off Node 14 and turn on Node 20 (and fix a bad type) #6169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haltman-at
added
dependencies
Pull requests that update a dependency file
internal improvement
labels
Aug 22, 2023
haltman-at
requested review from
gnidan,
davidmurdoch,
cds-amal,
eggplantzzz and
cliffoo
August 22, 2023 23:09
OK, added a commit to update hardhat, let's see how that goes... |
hardhat * @truffle/dashboard-hardhat-plugin: ^2.0.0 → ^2.17.1, ^2.0.0 → ^2.17.1 * @truffle/from-hardhat: ^2.10.1 → ^2.17.1
haltman-at
force-pushed
the
ganache-and-node-forward
branch
from
August 24, 2023 21:34
70287d3
to
53a1647
Compare
OK, going with latest hardhat, but I fixed the bad type in compile-solidity. |
haltman-at
changed the title
Update Ganache to 7.9.1; turn off Node 14 and turn on Node 20
Update Ganache to 7.9.1; turn off Node 14 and turn on Node 20 (and fix a bad type)
Aug 24, 2023
OK, I also had to update how Ganache is initialized in one place; we'll see if there are any others. |
OK, I have no idea why this test of |
gnidan
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this :D
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described!
I noticed some warnings in dashboard when bootstrapping this one that I hadn't seen before? But that may possibly be due to me switching to Node 16 rather than using Node 14 like I had been.