-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update for web3 1.0 #789
Update for web3 1.0 #789
Conversation
Those lasts fixes are really great news ! I've been digging through the web3-one branches of the multiples tools you had to update in order to be able to have web3 1.0.x run. That's some complex work ! With the arrival of web3 1.0.x i have a small question though as i'm questionning myself about it. Will we be able to load some wallets outside the ganache-cli | geth node and use them in the truffle-contract library ? I've been trying with the current version ( using the 0.20.0 package ) but the lib has been spitting some exceptions. I was wondering that if loading a provider with some web3.eth.wallet.add() instructions we would be able to use such loaded wallets in order to sign the transactions ? That would be a great improvement as it would really ease the use of the contracts with addresses that are not coming directly from the node and would allow using the wallets outside of plugins like metamask. Anyway, great work ! Thanks for the effort ! |
@Asone Yes, definitely agree we should try to make Also if you're testing |
Modifies tests so they pull a web3 1.0 compatible version of the MetaCoin project and translate
uint
values tonumber
withparseInt
instead of.toNumber
.Makes Web3 1.0 web-packable - it has a dependency which conditionally requires
electron
without using it and webpack complains about not being able to find it.(Code has been added to pull in a branch of
truffle-init-default
so that everything runs clean in CI. Will need to be removed after that branch is merged, before this branch is merged)