-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
difference between online translator and this library #58
Comments
also |
one more: the prov library doesn't distinguish between these two:
it merges them into one. |
@trungdong - i hope you don't mind me bombarding with questions. i'm trudging through the tests and they sometimes raise questions: for example:
how does prov deal with the fact that plan is None or plan is undefined? |
the problem with the example in |
Hi @satra, I have no problem at all. On the contrary, thank you very much for bringing these issues to our attention. As you discovered, the PROV-N output has bugs. The main reason is that we don't have round-trip tests for them. These are annoying and is not helpful when you use them for debugging, but not critical. The issue when QName and URI are merged is more important. I think this is caused by their hash function, which hashes only on the URI string. I'll look into this in a bit. Sorry for my delay in responding. I'm saturated at the moment. |
Just fixed the merging of URI and QName in d8be84a. |
I could not reproduce the issue with prov:plan = None in an association. The output on my machine is: |
* upstream/master: Fixed: PROV-N representation for xsd:dateTime (closed trungdong#58) Fixed: Unintended merging of Identifier and QualifiedName values
@trungdong - the None was a bug introduced in the rdf serializer that changed the graph representation. sorry for the noise there. |
using the following example as input to this library and the online translator there is a difference in how qnames are handled. is there a definitive answer? (i would prefer what the online translator did)
https://github.com/trungdong/prov/blob/master/prov/tests/json/activity6.json
the main difference is how the element with type xsd:QName is handled.
Prov library
Online translator
The text was updated successfully, but these errors were encountered: