deserialize_identifier: add support for all types expected by serde #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
deserialize-indexed
branch
from
387cb26
to
327f723
Compare
sosthene-nitrokey
changed the title
sosthene-nitrokey
force-pushed
the
deserialize-indexed
branch
from
62ee109
to
c7c15eb
Compare
sosthene-nitrokey
force-pushed
the
deserialize-indexed
branch
2 times, most recently
from
cdc43bc
to
2c31cf2
Compare
sosthene-nitrokey
force-pushed
the
deserialize-indexed
branch
2 times, most recently
from
3ba7c54
to
ced13e4
Compare
This was referenced Oct 2, 2024
The default serde deserialize derive accepts 3 types for identifiers: - The name of the field as `str` - The name of the field as ascii bytes - The index of the field as u64 This PR changes deserialize_identifier to have compatibility with all of these This is necessary for Nitrokey/fido-authenticator#57, which needs compatibility with both the str variant and the index variant
Previously, we visited either strings or bytes so that the visitor had to handle both cases. With this change, we always visit strings so that the bytes visitor function can be optimized out. This significantly reduces binary size.
sosthene-nitrokey
force-pushed
the
deserialize-indexed
branch
from
ced13e4
to
e025b33
Compare
robin-nitrokey
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default serde deserialize derive accepts 3 types for identifiers:
strThis PR changes deserialize_identifier to have compatibility with all of these
This is necessary for Nitrokey/fido-authenticator#57,
which needs compatibility with both the str variant and the index variant
Built on top of #7