Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4.0 release #4

Closed
sosthene-nitrokey opened this issue Dec 8, 2023 · 1 comment
Closed

0.4.0 release #4

sosthene-nitrokey opened this issue Dec 8, 2023 · 1 comment

Comments

@sosthene-nitrokey
Copy link
Contributor

Updating to the latest heapless release is a breaking change, it might be an occasion to add other breaking changes to a 0.4.0 release.

  • Remove the remove method: It is already implemented through Deref in heapless (though in a panicking way), and is unused as far as I know.
  • Remove the cbor feature. In can very easily be implemented outside of the crate and is unlikely to be used since the Bytes struct is meant to be used within a struct.
  • Remove the from function. It conflicts with the From trait.

Ideally I would even go to the point of removing the Deref trait impl and directly re-implementing all the heapless functions on top of it. This would make the documentation clearer. It would still be possible to implement From/Into a heapless Vec. This would make it possible to deref directly to a [u8].

This was referenced Jun 19, 2024
@robin-nitrokey
Copy link
Member

I think this has been solved by #8 and is included in v0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants