Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove heapless from public API #5

Closed
sosthene-nitrokey opened this issue Jun 19, 2024 · 3 comments
Closed

Remove heapless from public API #5

sosthene-nitrokey opened this issue Jun 19, 2024 · 3 comments

Comments

@sosthene-nitrokey
Copy link
Contributor

#4 already suggested removing the Deref implementation for better ergonomics.

I also suggest removing heapless from the public API, outside of simple From/Into, AsRef etc... implementations, behind a feature flag called heapless-0-8.

Concern by @robin-nitrokey in #3 :

          I also thought about removing the public heapless dependency.  But AFAIS we don’t have a way to support multiple heapless versions because heapless does not have a way to construct a vec from raw parts.

This can be implemented manually through copying if necessary. This is IMHO better than have a breaking change.

@robin-nitrokey
Copy link
Member

Copying is fine for conversions, but I think it would be very counter-intuitive for AsRef or Deref implementations.

@sosthene-nitrokey
Copy link
Contributor Author

Right. And we'll want to update mostly for the view types, and the semver compatibility of that pattern is questionable, so we might want a breaking change here too.

@sosthene-nitrokey
Copy link
Contributor Author

Done in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants