read_dir_first: stop at the first file that is alphabetically "after" not_before
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `not_before` In fido-authenticator, if we change the paths of RK to be: "rp_id.rk_id" instead of the current "rp_id/rk_id", we still want to be able to iterate over the keys even though we only know the "rp_id" and not the "rk_id". Therefore we need to be able to stop at "rp_id.***" when giving "rp_id" in `not_before` This is technically a breaking change because now, given the files: - "aaa" - "aaabbb" "read_dir_first" with "aaa" as `not_before` would only yield "aaa" due to littlefs-project/littlefs#923. Now this will yield both files, and yield "aaabbb" first. I beleive this behaviour is technically more correct as it is likely what would be expected to be yield expecting alphabetical order (though the order of the entries is still incorrect).
src/api.rs
Outdated
| @@ -244,7 +244,7 @@ pub mod request { | |||
| ReadDirFirst: | |||
| - location: Location | |||
| - dir: PathBuf | |||
| - not_before_filename: Option<PathBuf> | |||
| - not_before: Option<(PathBuf, bool)> | |||
There was a problem hiding this comment.
I don’t like this tuple, it’s very hard to understand. What do you think about moving the bool into a separate field that only has an effect if not_before_filename is set? Alternatively, a helper struct could be used.
There was a problem hiding this comment.
I replaced it with an enum with 3 states.
sosthene-nitrokey
force-pushed
the
iteration-cmp-upstream
branch
from
b2caa29
to
c7f2991
Compare
robin-nitrokey
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fido-authenticator, if we change the paths of RK to be: "rp_id.rk_id" instead of the current "rp_id/rk_id", we still want to be able to iterate over the keys even though we only know the "rp_id" and not the "rk_id". Therefore we need to be able to stop at "rp_id.***" when giving "rp_id" in
not_beforeThis is technically a breaking change because now, given the files:
"read_dir_first" with "aaa" as
not_beforewould only yield "aaa"due to littlefs-project/littlefs#923. Now this will yield both files, and yield "aaabbb" first.
I beleive this behaviour is technically more correct as it is likely what would be expected to be yield expecting alphabetical order (though the order of the entries is still incorrect).