ci: Use pull_request_target event for semantic PR workflow #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzubara
requested review from
gidjin,
haworku,
sarboc,
SirenaBorracha and
tinyels
as code owners
suzubara
changed the title
suzubara
changed the title
ahobson
previously approved these changes
Mar 15, 2021
ahobson
approved these changes
Mar 15, 2021
brandonlenz
pushed a commit
that referenced
this pull request
May 12, 2021
* Use pull_request_target event for semantic PR workflow * Temp add this branch to test workflow * Remove this branch name from workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the newly introduced
pull_request_targetevent to trigger the semantic PR workflow. This ensures semantic PR workflow is always run against the config in the base branch of a PR, allowing PRs from forks to run workflows without worrying that they are changing config. This should also fix an issue where Dependabot PRs are failing with the error:Error: Resource not accessible by integration(source)Note, I added this branch to the config in order to test that it actually fixed the Dependabot issue (since
pull_request_targetmeans the base branch of a PR needs to include updated config). When this PR is approved I will remove it.