Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove validation of optional service properties #335

Closed
llorllale opened this issue Jul 2, 2020 · 5 comments · Fixed by #374
Closed

remove validation of optional service properties #335

llorllale opened this issue Jul 2, 2020 · 5 comments · Fixed by #374
Assignees
Labels
Milestone

Comments

@llorllale
Copy link
Contributor

The sidetree spec mandates the inclusion of id, type, and endpoint in each service entry: https://identity.foundation/sidetree/spec/#add-service-endpoints.

Beyond those, it does not prescribe any limitation on additional fields that may be included. This check should therefore be removed.

@sandrask
Copy link
Contributor

sandrask commented Jul 6, 2020

A month ago or so spec allowed only for "MUST" properties and @troyronda wanted to include additional properties only if they are on 'allowed' list. @troyronda Do you still want a check for properties added in add-service-endpoint patch or I should I remove check as @llorllale suggested?

@sandrask
Copy link
Contributor

@troyronda any decisions on my comment above

@llorllale
Copy link
Contributor Author

@sandrask @troyronda checks for specific fields outside those absolutely required by did-core (id, type, endpoint) would encumber extensions to did documents (ie. custom vocabularies that extend service entries).

@sandrask
Copy link
Contributor

@llorllale I agree that removing restrictions is more flexible so I am for it @troyronda just has to confirm it is ok to remove allowed list (since it was his idea to create it)

@sandrask sandrask self-assigned this Aug 13, 2020
@sandrask sandrask added the chore label Aug 13, 2020
@sandrask sandrask added this to the 0.1.4 milestone Aug 13, 2020
@sandrask
Copy link
Contributor

After discussion with @llorllale and @troyronda it has been decided to disable validation of optional service endpoint fields. New issue has been created #373

sandrask added a commit to sandrask/sidetree-core-go that referenced this issue Aug 13, 2020
Remove validation of optional service properties

Closes trustbloc#335

Signed-off-by: Sandra Vrtikapa <[email protected]>
sandrask added a commit to sandrask/sidetree-core-go that referenced this issue Aug 13, 2020
Remove validation of optional service properties

Closes trustbloc#335

Signed-off-by: Sandra Vrtikapa <[email protected]>
sandrask added a commit to sandrask/sidetree-core-go that referenced this issue Aug 13, 2020
Remove validation of optional service properties

Closes trustbloc#335

Signed-off-by: Sandra Vrtikapa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants