Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

chore: bdd tests should not use OAuth2 authentication to auth service #340

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

ypukhta
Copy link
Contributor

@ypukhta ypukhta commented Sep 30, 2022

Issue trustbloc/auth#286

Note:
I had to change in KMS makefile golang-cross image tag from latest to 1.18 to workaround the following error:

Building kms cli binaries
go: downloading github.com/spf13/cobra v1.3.0
go: downloading github.com/trustbloc/edge-core v0.1.8
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/stretchr/testify v1.7.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
kms-cli-linux-amd64
kms-cli-linux-arm64
# runtime/cgo
cgo: C compiler "aarch64-apple-darwin20.2-clang" not found: exec: "aarch64-apple-darwin20.2-clang": executable file not found in $PATH
make: *** [Makefile:53: build-kms-cli-binaries] Error 2
Error: Process completed with exit code 2.

ghcr.io/gythialy/golang-cross:latest was updated a day ago and seems introduced this issue. Didn't dig deep, though.

Signed-off-by: Yevgen Pukhta [email protected]

@cla-bot cla-bot bot added the cla-signed label Sep 30, 2022
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 86.45% // Head: 86.45% // No change to project coverage 👍

Coverage data is based on head (ca4cc8a) compared to base (412f152).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   86.45%   86.45%           
=======================================
  Files          24       24           
  Lines        2119     2119           
=======================================
  Hits         1832     1832           
  Misses        182      182           
  Partials      105      105           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ypukhta ypukhta force-pushed the issue-auth-256-remove-oidc-auth branch from 84d1662 to ca4cc8a Compare September 30, 2022 17:21
@ypukhta ypukhta marked this pull request as ready for review September 30, 2022 17:44
@ypukhta ypukhta changed the title chore: bdd tests don't use OAuth2 authentication to auth service chore: bdd tests should not use OAuth2 authentication to auth service Sep 30, 2022
@fqutishat fqutishat merged commit 342d363 into trustbloc:main Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants