This repository has been archived by the owner on Jun 2, 2019. It is now read-only.
Link "Settings → Telegram Group" should open channel according to user's locale #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikmeup
approved these changes
Aug 3, 2018
| @@ -36,7 +36,9 @@ enum URLServiceProvider { | |||
| case .twitter: | |||
| return URL(string: "twitter://user?screen_name=\(Constants.twitterUsername)")! | |||
| case .telegram: | |||
| return URL(string: "tg://resolve?domain=\(Constants.telegramUsername)") | |||
| let languageCode = NSLocale.preferredLanguageCode ?? "" | |||
There was a problem hiding this comment.
can you move this code into a function? it's been reused below
ghost
pushed a commit
that referenced
this pull request
Aug 6, 2018
…ansactions * master: Move reload into separate function Crash: Signing on watch address via browser #885 fix crash when signing on watch address via browser #885 (#887) Update localized string and use R Move into separate function Update Analitics.swift (#882) Link "Settings → Telegram Group" should open channel according to user's locale (#879) Improve currentWalletDescriptionString Move Help center higher in order Version Bump
ghost
pushed a commit
that referenced
this pull request
Aug 6, 2018
* master: Move reload into separate function Crash: Signing on watch address via browser #885 fix crash when signing on watch address via browser #885 (#887) Update localized string and use R Move into separate function Update Analitics.swift (#882) Link "Settings → Telegram Group" should open channel according to user's locale (#879) Improve currentWalletDescriptionString Move Help center higher in order Version Bump
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing to #875