Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethereum new fee support EIP1559 #1322

Closed
optout21 opened this issue Mar 11, 2021 · 2 comments · Fixed by #1509
Closed

Ethereum new fee support EIP1559 #1322

optout21 opened this issue Mar 11, 2021 · 2 comments · Fixed by #1509
Assignees
Labels
enhancement New feature or request priority:medium

Comments

@optout21
Copy link
Contributor

optout21 commented Mar 11, 2021

Fee structure in Ethereum is planned to be changed.
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1559.md

Wallet core should support this, supporting both legacy and new version.
The base fee is determined by the network, no need for user input or estimation.
Optional tip (inclusion fee) is an option for the user.
Max fee is also a setting (user-supplied or fixed?).

A proposed way to support both schemes by extending ethreum SigningInput with new fields max_inclusion_fee_per_gas and max_fee_per_gas:

Discriminator: If gas_price > 0, legacy fee scheme is used; if gas_price == 0 new EIP1559 scheme is used.

Legacy pre-EIP1559 scheme: gas_price and gas_limit are used as before, new fields are disregarded.

EIP1559: new fields max_inclusion_fee_per_gas and max_fee_per_gas are used (maxInclusionFeePerGas, maxFeePerGas, gas_limit is used, `gas_price' is disregarded (must be 0).

Note: EIP-2718 is a prerequisite, as EIP1559-compliant transaction is a new EIP-2718 type.

@optout21
Copy link
Contributor Author

Postpone committing EIP2718 support to the time when EIP1559 is approaching.

@optout21
Copy link
Contributor Author

EIP1559 is already active on the Ropsten test network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants