Refactor Eth Transaction for EIP2718 #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 30, 2021 16:38
Codecov Report
@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
- Coverage 95.41% 95.39% -0.02%
==========================================
Files 443 443
Lines 13401 13336 -65
==========================================
- Hits 12786 12722 -64
+ Misses 615 614 -1
Continue to review full report at Codecov.
|
optout21
changed the title
5 tasks
hewigovens
reviewed
Apr 8, 2021
added 2 commits
April 8, 2021 15:23
hewigovens
approved these changes
Apr 8, 2021
|
Postpone committing EIP2718 support to the time when EIP1559 is approaching. |
vikmeup
approved these changes
Jul 6, 2021
SHH-HaoZhang
pushed a commit
to monacohq/wallet-core
that referenced
this pull request
Oct 15, 2021
* Add new fields to Ethereum proto. * Legacy transaction building. * Typescript test update * TS test fix * Compiler warning fix (ios) * Legacy and Enveloped transactions. * lSigner. Refactor Transaction * AccessList generation test (wip) * Cleanup, small refactor * Signer build change, make it more generic. * Copyright year * SignatureRSV rename. * Signer class is static now, no chainID memeber. * Renames, Legacy * Minor touches * Rename, hash * Minor reorg in sign() Co-authored-by: Catenocrypt <[email protected]>
cornbread78
pushed a commit
to cornbread78/wallet-core
that referenced
this pull request
Dec 22, 2021
* Add new fields to Ethereum proto. * Legacy transaction building. * Typescript test update * TS test fix * Compiler warning fix (ios) * Legacy and Enveloped transactions. * lSigner. Refactor Transaction * AccessList generation test (wip) * Cleanup, small refactor * Signer build change, make it more generic. * Copyright year * SignatureRSV rename. * Signer class is static now, no chainID memeber. * Renames, Legacy * Minor touches * Rename, hash * Minor reorg in sign() Co-authored-by: Catenocrypt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor Eth Transaction, for legacy and enveloped EIP2718 transactions. EIP2718 is a prerequisite for upcoming EIP1559 new fee structure, and EIP2718 is part of the Berlin update, expected to to arrive mid-April.
Related to #1322 .
Testing instructions
Unit tests.
Types of changes
Checklist
[WIP]if necessary.