Kotlin multiplatform leaking memory

[vcoolish]

Fixes #4021

Android:

Before	After

iOS:

BeforeStart	BeforeEnd	AfterStart	AfterEnd

[github-actions]

Binary size comparison

➡️ aarch64-apple-ios: 12.13 MB

➡️ aarch64-apple-ios-sim: 12.14 MB

➡️ aarch64-linux-android: 15.57 MB

➡️ armv7-linux-androideabi: 13.29 MB

➡️ wasm32-unknown-emscripten: 11.03 MB

[10gic]

Hi @vcoolish, glad to see this fixed. Could you provide some test data after the fix?

[vcoolish]

Hi @vcoolish, glad to see this fixed. Could you provide some test data after the fix?

attached android and ios data, for JS I couldn't get memory usage increase yet

[satoshiotomakan]

Thank you for the fix! I have one note

[satoshiotomakan]

Do we spawn a new thread for each instance of HDWallet, AnyAddress etc?
I saw examples do the same, but it's not optimal. What if we have one PhantomReferenceRegistry singleton class that spawns one thread, and AnyAddress.init() and HDWallet.init() just register the nativeHandle with a corresponding delete function.
So the pseudocode will look like:

class AnyAddress {
  init {
        PhantomReferenceRegistry.getOrCreate().register(nativeHandle, TWAnyAddressDelete)
    }
}

class PhantomReferenceRegistry {
  init {
    Thread {
      doDeletes()
    }
  }

  // Sends a pair of `nativeHandle` and `TWAnyAddressDelete(nativeHandle)` to the spawned thread.
  private val channel: Channel<Pair<Long, (Long)>>
}

[vcoolish]

thanks for suggestion, done

[satoshiotomakan]

Looks great to me!