-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add 1inch visualization supoprt #37
Open
gabrielantonyxaviour
wants to merge
23
commits into
trustwallet:main
Choose a base branch
from
gabrielantonyxaviour:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the hackathon bounty submission, we will check the submission this week. Can you please fix the failing tests? Thanks |
I will do it ASAP. Thank you |
Hey @a6-dou, sorry for the test issue. It was a small bug that went un-noticed. Fixed it. Thank you!🙌 |
a6-dou
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polygon DevX [Americas] Hackathon Submission
Problem Statement Visualization ($5000)
Support
Community
Innovation
Now as you are more familiar with wizard-sdk and the EIP-712 visualization concept, propose the best way to solve this widespread issue (it can be one of the 2 already existing ones, the SDK or on-chain visualization EIP, just make sure to defend your idea)
Solution
DoraHacks Submission here
Innovation
The transaction signature is crucial in preventing undesired situations for Ethereum users. It is of utmost importance that the authorization message provides users with a complete understanding of the implications that such authorization may have on their assets. To achieve this, on-chain visualization ERC-6865 messages (as opposed to off-chain solutions) is a better way to solve the issue.
From a security perspective, carrying out this message generation on-chain adds a layer of security and trust for both users and decentralized applications (dapps) that integrate these DeFi protocols.
It is highly beneficial for each protocol's development team to take responsibility for this implementation. This ensures greater accuracy in the generated information and eliminates two significant risk vectors:
Possible errors arising from third parties when implementing the functionality.
The potential for malicious dapps to issue messages with false information.
This empowers users who research the protocols they wish to interact with, as they can have confidence that the generation of messages for transaction signing has undergone audits and testing.