Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 1inch visualization supoprt #37

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

gabrielantonyxaviour
Copy link

Polygon DevX [Americas] Hackathon Submission

Problem Statement Visualization ($5000)

Support

  1. Add visualization support for both 1inch fusion and rarible

Community

  1. Create a registry smart contract that route to various EIP-6865 implementation of different protocols
  2. Create a smart contract that is compliant with EIP-6865 for 1inch fusion
    Innovation

Now as you are more familiar with wizard-sdk and the EIP-712 visualization concept, propose the best way to solve this widespread issue (it can be one of the 2 already existing ones, the SDK or on-chain visualization EIP, just make sure to defend your idea)

Material Bread logo

Solution

DoraHacks Submission here

  1. 1inch wizard sdk implementation in this Pull request
  2. 1InchEIP712Visualizer here

Innovation
The transaction signature is crucial in preventing undesired situations for Ethereum users. It is of utmost importance that the authorization message provides users with a complete understanding of the implications that such authorization may have on their assets. To achieve this, on-chain visualization ERC-6865 messages (as opposed to off-chain solutions) is a better way to solve the issue.

From a security perspective, carrying out this message generation on-chain adds a layer of security and trust for both users and decentralized applications (dapps) that integrate these DeFi protocols.

It is highly beneficial for each protocol's development team to take responsibility for this implementation. This ensures greater accuracy in the generated information and eliminates two significant risk vectors:

Possible errors arising from third parties when implementing the functionality.
The potential for malicious dapps to issue messages with false information.

This empowers users who research the protocols they wish to interact with, as they can have confidence that the generation of messages for transaction signing has undergone audits and testing.

@a6-dou
Copy link
Collaborator

a6-dou commented Nov 13, 2023

Thanks for the hackathon bounty submission, we will check the submission this week.

Can you please fix the failing tests? Thanks

@gabrielantonyxaviour
Copy link
Author

gabrielantonyxaviour commented Nov 14, 2023

I will do it ASAP. Thank you

@gabrielantonyxaviour
Copy link
Author

gabrielantonyxaviour commented Nov 14, 2023

Hey @a6-dou, sorry for the test issue. It was a small bug that went un-noticed. Fixed it. Thank you!🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants