-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support more customization for the job pod of the LMES #340
feat: support more customization for the job pod of the LMES #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM, I tested node affinity in another PR.
@tedhtchang: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PR image build and manifest generation completed successfully! 📦 PR image: 📦 LMES driver image: 📦 LMES job image: 🗂️ CI manifests
|
sorry for accidentally deleting my branch. let me rebase the PR and solve the conflict. |
b4313f0
to
5ad97c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ruivieira, tedhtchang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add the following fields to customize the LMES job pod: - `Affinity`: for node affinity - `SecurityContext`: for both pod and main container Also, merge the `SideCars` which is an array of extra containers into the final PodSpec along with the main container. Signed-off-by: Yihong Wang <[email protected]>
5ad97c8
to
8a31795
Compare
New changes are detected. LGTM label has been removed. |
@yhwang: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add the following fields to customize the LMES job pod:
Affinity
: for node affinitySecurityContext
: for both pod and main containerAlso, merge the
SideCars
which is an array of extra containers into the final PodSpec along with the main container.