Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support more customization for the job pod of the LMES #340

Merged

Conversation

yhwang
Copy link
Collaborator

@yhwang yhwang commented Oct 23, 2024

Add the following fields to customize the LMES job pod:

  • Affinity: for node affinity
  • SecurityContext: for both pod and main container

Also, merge the SideCars which is an array of extra containers into the final PodSpec along with the main container.

@yhwang yhwang requested a review from ruivieira October 23, 2024 22:12
@yhwang yhwang added the lm-eval Issues related to LM-Eval label Oct 23, 2024
Copy link
Contributor

@tedhtchang tedhtchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM, I tested node affinity in another PR.

Copy link

openshift-ci bot commented Oct 24, 2024

@tedhtchang: changing LGTM is restricted to collaborators

In response to this:

/LGTM, I tested node affinity in another PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Oct 24, 2024

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:8a317952dd40f5eaeb378077cdf919e82c80fc7f

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver:8a317952dd40f5eaeb378077cdf919e82c80fc7f

📦 LMES job image: quay.io/trustyai/ta-lmes-job:8a317952dd40f5eaeb378077cdf919e82c80fc7f

🗂️ CI manifests

devFlags:
  manifests:
    - contextDir: config
      sourcePath: ''
      uri: https://api.github.com/repos/trustyai-explainability/trustyai-service-operator-ci/tarball/operator-8a317952dd40f5eaeb378077cdf919e82c80fc7f

@openshift-ci openshift-ci bot added the lgtm label Oct 25, 2024
@yhwang yhwang closed this Oct 28, 2024
@yhwang yhwang deleted the update-lmevaljob-pod branch October 28, 2024 17:08
@yhwang yhwang restored the update-lmevaljob-pod branch October 29, 2024 16:35
@yhwang yhwang reopened this Oct 29, 2024
@yhwang
Copy link
Collaborator Author

yhwang commented Oct 29, 2024

sorry for accidentally deleting my branch. let me rebase the PR and solve the conflict.

Copy link
Member

@ruivieira ruivieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@openshift-ci openshift-ci bot added the lgtm label Oct 29, 2024
Copy link

openshift-ci bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ruivieira, tedhtchang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Add the following fields to customize the LMES job pod:
- `Affinity`: for node affinity
- `SecurityContext`: for both pod and main container

Also, merge the `SideCars` which is an array of extra containers into
the final PodSpec along with the main container.

Signed-off-by: Yihong Wang <[email protected]>
Copy link

openshift-ci bot commented Nov 4, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Nov 4, 2024

@yhwang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e 8a31795 link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ruivieira ruivieira merged commit 21d43de into trustyai-explainability:main Nov 5, 2024
4 of 6 checks passed
@yhwang yhwang deleted the update-lmevaljob-pod branch November 7, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lm-eval Issues related to LM-Eval ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants