Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Allow smoke test to pass #356

Merged

Conversation

tedhtchang
Copy link
Contributor

Allow smoke test to pass

Signed-off-by: ted chang <[email protected]>
Copy link

openshift-ci bot commented Nov 8, 2024

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a trustyai-explainability member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Nov 8, 2024

@tedhtchang: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@ruivieira ruivieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! LGTM, thanks @tedhtchang

Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ruivieira

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented Nov 8, 2024

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:84635a07005e16c524ddcde45883b3e65c0ad8b6

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver:84635a07005e16c524ddcde45883b3e65c0ad8b6

📦 LMES job image: quay.io/trustyai/ta-lmes-job:84635a07005e16c524ddcde45883b3e65c0ad8b6

🗂️ CI manifests

devFlags:
  manifests:
    - contextDir: config
      sourcePath: ''
      uri: https://api.github.com/repos/trustyai-explainability/trustyai-service-operator-ci/tarball/operator-84635a07005e16c524ddcde45883b3e65c0ad8b6

@ruivieira ruivieira changed the title allow smoke test to pass fix(test): Allow smoke test to pass Nov 8, 2024
@ruivieira ruivieira merged commit a652c60 into trustyai-explainability:main Nov 8, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants