This repository has been archived by the owner on May 5, 2024. It is now read-only.
Refactor prom rules #947
Merged
Refactor prom rules #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trux-bot
bot
added
size/L
|
Path: |
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ BASH | bash-exec | 1 | 0 | 0.01s | |
| ✅ BASH | shellcheck | 1 | 0 | 0.02s | |
| shfmt | 1 | 1 | 0.01s | ||
| ✅ COPYPASTE | jscpd | yes | no | 0.82s | |
| ✅ CREDENTIALS | secretlint | yes | no | 1.62s | |
| ✅ GIT | git_diff | yes | no | 0.02s | |
| ✅ KUBERNETES | kubeval | 37 | 0 | 2.72s | |
| misspell | 39 | 1 | 0.05s | ||
| prettier | 38 | 1 | 1.42s | ||
| ✅ YAML | v8r | 38 | 0 | 19.9s | |
| ✅ YAML | yamllint | 38 | 0 | 0.53s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor prometheus rules to one folder.
This aids in visibility of prom setup & keeping track of setup.
it is misaligned to usual cluster standard (of having them in each apps folder) but helps with managing race conditions