Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export ICourierClient from main #33

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

jrweingart
Copy link
Contributor

@jrweingart jrweingart commented Mar 2, 2021

Description of the change

-ICourierClient now exported from main entry point

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@linear
Copy link

linear bot commented Mar 2, 2021

C-2235 Export ICourierClient

Small ask - can you export the type ICourierClient from @trycourier/courier? We’re using typescript and now we have to import it from @trycourier/courier/lib/types which feels flaky

@jrweingart jrweingart merged commit 97ed205 into master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants