Feat/iri widget enhancement #86
Conversation
Make the external icon optional to render. Default is true.
Add URL prefix to iri link if provided. Iri get encoded in this case.
Add a copy to clipboard button for iri. Default is false.
Add new stories for the iriWidget added features.
Pooya-Oladazimi
requested review from
rombaum,
julian-schneider and
jusa3
and removed request for
julian-schneider
There was a problem hiding this comment.
Nice new features! Please also add stories to the HTML Storybook, by exporting them in the IriWdgetHTML.stories.ts. I will adapt the readme and make it more clear for developers to update both, the React and html stories (#88)
And please merge the latest changes I made on the main branch, since this will activate the build check for pull requests. Thank you :)
Add the new stories for the HTML version.
|
Not ready yet. The new features do not work in the HTML version for some unknown reason. The stories are there but the input props have no effect. |
src/app/types.ts
Outdated
| /** | ||
| * Indicates that the target is external and needs an icon. | ||
| */ | ||
| externalIcon?: string; |
There was a problem hiding this comment.
why not use boolean? same for copyButton
There was a problem hiding this comment.
Yes true. I can't remember why I set it to string. I will do a fix-commit for this.
change the boolean types to boolean. Refactor the story. Use color also for the copy button.
|
🎉 This PR is included in version 2.0.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Related to #84
Added Features: