Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ols4 search #94

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Fix/ols4 search #94

merged 3 commits into from
Jun 20, 2024

Conversation

jusa3
Copy link
Collaborator

@jusa3 jusa3 commented Jun 20, 2024

Differences on OLS3/OLS4 API facet keys:

OLS3: response["facet_counts"]["facet_fields"]["ontology_name"]
OLS4: response["facet_counts"]["facet_fields"]["ontologyId"]

-> Added useLegacy parameter and condition in useQuery API call.

Also fixed minor bug in BreadcrumbPresentation.

@jusa3 jusa3 requested a review from rombaum June 20, 2024 07:18
…n for an OLS3 API in the autocomplete result list.
@rombaum rombaum merged commit 06f47cb into main Jun 20, 2024
2 checks passed
@rombaum rombaum deleted the fix/ols4-search branch June 20, 2024 09:43
@jusa3
Copy link
Collaborator Author

jusa3 commented Jun 20, 2024

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants