It runs!

tsalo · Apr 7, 2024 · ba6ebea · ba6ebea
1 parent 36086ac
commit ba6ebea
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/sdcflows/interfaces/fmap.py b/sdcflows/interfaces/fmap.py
@@ -723,7 +723,11 @@ def _run_interface(self, runtime):
 
             unwrapped_mat = phase_volume_data.reshape(-1, n_echoes).T
             weights = magnitude_volume_data.reshape(-1, n_echoes).T
-            b0 = weighted_regression(echo_times, unwrapped_mat, weights)[0].T.reshape(*size)
+            b0 = weighted_regression(
+                echo_times[:, np.newaxis],
+                unwrapped_mat,
+                weights,
+            )[0].T.reshape(*size)
             b0 *= 1000 / (2 * np.pi)
             out_b0[:, :, :, i_vol] = b0
 

diff --git a/sdcflows/interfaces/utils.py b/sdcflows/interfaces/utils.py
@@ -848,7 +848,15 @@ def _run_interface(self, runtime):
                 Y = phase_unwrapped[volume_mask, :j_echo, i_vol].T
 
                 # fit model to data
-                coefficients, _ = weighted_regression(X[:j_echo], Y, weights_mat[:j_echo])
+                # XXX: Small change from warpkit:
+                # weights_mat[:j_echo, i_vol, :] instead of weights_mat[:j_echo]
+                # Otherwise, coefficients is voxels x time instead of just voxels
+                # Not sure what the issue is.
+                coefficients, _ = weighted_regression(
+                    X[:j_echo],
+                    Y,
+                    weights_mat[:j_echo, i_vol, :],
+                )
 
                 # get the predicted values for this echo
                 Y_pred = coefficients * echo_times[j_echo]