Test on Windows #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path._makeLong function will return paths like these on Windows:
\\?\c:\foo\bar
The fs.realpath function walks through Windows paths treating '\\?\c:\' as the base directory, so this is what we store. The process.cwd and os.tmpdir functions may not return the same case for base directory names, so we normalize to lowercase.
|
With these changes, 427 passing (none failing) on Windows 7 with Node 0.10 and 0.11. There is one test failure on Windows with Node 0.8 (see #4). |
tschaub
added a commit
that referenced
this pull request
Jan 13, 2014
Confirm that tests pass on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirm that tests pass on Windows.