engines block to specify min requirements
#337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per [the 5.0.0 release notes](https://github.com/tschaub/mock-fs/releases/tag/v5.0.0), support for Node less than 12 has been dropped. With an `engines` block, `npm` can issue an error to tell folks on Node 10 (or other lower/unsupported version) that the package is no longer compatible. This can save time for things like #334 where it's not obvious why issues are occurring.
|
LGTM @tschaub |
tschaub
approved these changes
Sep 23, 2021
|
Thanks, @tillig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the 5.0.0 release notes, support for Node less than 12 has been dropped. With an
enginesblock,npmcan issue an error to tell folks on Node 10 (or other lower/unsupported version) that the package is no longer compatible. This can save time for things like #334 where it's not obvious why issues are occurring.