Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fs.access binding #78

Merged
merged 1 commit into from
Jan 31, 2016
Merged

Add fs.access binding #78

merged 1 commit into from
Jan 31, 2016

Conversation

shyiko
Copy link
Contributor

@shyiko shyiko commented Jan 30, 2016

No description provided.

@tschaub tschaub mentioned this pull request Jan 31, 2016
Closed
@tschaub
Copy link
Owner

tschaub commented Jan 31, 2016

Thanks for the contribution @shyiko. I'll add some fs.access() tests and cut a new release with this soon.

tschaub added a commit that referenced this pull request Jan 31, 2016
@tschaub
Merge pull request #78 from shyiko/fs_access
e2df8af 
Add fs.access binding.
@tschaub tschaub merged commit e2df8af into tschaub:master Jan 31, 2016
@shyiko
Copy link
Contributor Author

shyiko commented Jan 31, 2016

@tschaub Thank you!

@tschaub tschaub mentioned this pull request Jan 31, 2016
Merged
@tschaub
Copy link
Owner

tschaub commented Jan 31, 2016

The docs make it look like fs.access() works on Windows as well. If anybody knows how that works (without process.getuid() and process.getgid()), enhancements to binding.access() are welcome.

@tschaub
Copy link
Owner

tschaub commented Jan 31, 2016

Published as [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shyiko @tschaub