Implement binding.writeBuffers() #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@tschaub I just checked out this pull request and ran it against my reduced test case and it passed. Thank you! |
tschaub
added a commit
that referenced
this pull request
Mar 7, 2016
Implement binding.writeBuffers().
|
Fantastic, thank you! 👍 |
|
Published as |
|
@tschaub no problem! I just pulled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an implementation for
binding.writeBuffers(). Thefsuses a newbinding.writeBuffers()method in implementing the stream's_writevmethod. The_writevmethod in turn looks to be called when there is a buffered write request. In Node >= 0.12, this happens when callingwriteon a corked stream. So the integration tests for the newwriteBuffers()method corks, writes to, and then uncorks a write stream.Fixes #88.