Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addedd support for h2c requests (HTTP/2 without TLS) #261

Merged
merged 1 commit into from
May 8, 2018

Conversation

mzdeb
Copy link
Contributor

@mzdeb mzdeb commented Sep 19, 2017

Hi,

It's my first PR here, and first in golang. ;) Thank you very much for your hard work on this project.

Probably support for h2c might be done better, so any suggestions welcome.

@tsenart
Copy link
Owner

tsenart commented Sep 19, 2017

How does this relate to golang/go#14141?

@mzdeb
Copy link
Contributor Author

mzdeb commented Sep 19, 2017

As bradfitz wrote:

I've already accepted a ton of logic for h2c. My policy has been and remains: it should be possible for people to do h2c via a separate package, but it won't be supported by default.
All the pieces should be there now for you to glue it together yourself.
For server-side support you'll need to hijack in the PRI * HTTP/2.0 Handler and then call http2.Server.ServerConn.

So currently H2C is quite simple for client to implement. When golang/go#16581 will be resolved, all options from http.Transport will be also available.

@awinder
Copy link

awinder commented Mar 1, 2018

I've gotta 👍 this issue because I'm currently impacted by the same issue and it looks like several months have elapsed without any closure from the upstream golang PRs. Any chance of reviving this?

Copy link
Owner

@tsenart tsenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsenart tsenart merged commit a744dc7 into tsenart:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants