-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destructuring of Ember.testing
will not work.
#17
Comments
Will do. Thanks for the heads up @rwjblue. I wonder why GitHub never sent me an email notification about a new issue. Lol |
Haha, no problem! I struggle with missing notifications too... |
tsteuwer
added a commit
that referenced
this issue
Mar 23, 2018
tsteuwer
added a commit
that referenced
this issue
Mar 23, 2018
Fixing #17 - removing destructuring of Ember.testing
Fixed in release v0.5.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ember.testing
is a getter/setter in Ember, and destructuring like this will only read its value at the time the module is evaluated. In this case,Ember.testing
will most likely befalse
when the module is evaluated, then change totrue
during the test. This behavior somewhat recently changed in emberjs/ember-test-helpers#227 (which is included in[email protected]
/[email protected]
).I believe the fix here would be to remove the destructuring, and use
Ember.testing
directly inline.ember-tracker/addon/mixins/tealium-route.js
Lines 16 to 20 in 2b2c86e
ember-tracker/addon/mixins/tealium-route.js
Lines 38 to 40 in 2b2c86e
The text was updated successfully, but these errors were encountered: