Corrected wrong calls from .on to .off (elastic#24575) (elastic#26805)

Closing memory leak
tsullivan · Dec 7, 2018 · 30de693 · 30de693
1 parent bb79d69
commit 30de693
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/legacy/core_plugins/metrics/public/visualizations/components/flot_chart.js b/src/legacy/core_plugins/metrics/public/visualizations/components/flot_chart.js
@@ -65,9 +65,9 @@ class FlotChart extends Component {
 
   shutdownChart() {
     if (!this.plot) return;
-    $(this.target).unbind('plothover', this.props.plothover);
-    if (this.props.onMouseOver) $(this.target).on('plothover', this.handleMouseOver);
-    if (this.props.onMouseLeave) $(this.target).on('mouseleave', this.handleMouseLeave);
+    $(this.target).off('plothover', this.props.plothover);
+    if (this.props.onMouseOver) $(this.target).off('plothover', this.handleMouseOver);
+    if (this.props.onMouseLeave) $(this.target).off('mouseleave', this.handleMouseLeave);
     if (this.props.onBrush) $(this.target).off('plotselected', this.brushChart);
     this.plot.shutdown();
     if (this.props.crosshair) {