Assign Roles to Space #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me so far. |
eokoneyo
force-pushed
the
feat/assigning-roles-to-space
branch
2 times, most recently
from
b8a5897
to
2f76b4f
Compare
eokoneyo
force-pushed
the
feat/assigning-roles-to-space
branch
from
2f76b4f
to
97ec872
Compare
eokoneyo
force-pushed
the
feat/assigning-roles-to-space
branch
from
97ec872
to
e5f24ac
Compare
|
Marked this for ready for review, so it can be included in the body of work to be reviewed in the CDR meeting. There will be a follow up PR to completely address the assign to role task. Especially that we are waiting on elastic#187427 |
tsullivan
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on #11, focuses primarily on the business logic and UI interaction involved with assigning several roles to a space.
A user that doesn't have capabilities to view roles will not be presented the roles tab, and in the same vein a user that doesn't have capability to save a modification to roles definition will not be presented options to modify roles assigned to a space. See elastic#181315 for more clarification.