Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further improvements to spaces role assignment tab #14

Merged
merged 26 commits into from
Aug 28, 2024
Merged

Further improvements to spaces role assignment tab #14

merged 26 commits into from
Aug 28, 2024

Conversation

eokoneyo
Copy link

@eokoneyo eokoneyo commented Jul 24, 2024 •
edited
Loading

Summary

  • Incorporates the most recent design for the spaces assigned roles table
  • Integrates privilege table for specifying custom privileges for any selected role
  • includes support for bulk modifying roles already assigned to a space

Visuals

Screenshot 2024-08-02 at 17 52 55 Screenshot 2024-08-28 at 16 26 02

@eokoneyo eokoneyo force-pushed the assign-roles-to-space branch 3 times, most recently from 3f33935 to a3f3cda Compare July 29, 2024 15:02
@eokoneyo eokoneyo force-pushed the assign-roles-to-space branch 9 times, most recently from 7cb3adf to e818aa4 Compare August 28, 2024 10:18
@eokoneyo
create spaces assigned role table
2338e06
@eokoneyo
extend definition of roles that can be edited
8872a5d
@eokoneyo
fix pluralization in select all button
bb69ad5
@eokoneyo
slight adjustments rendered items count
73a0dd1
@eokoneyo
fix text, and hide assign to space button when there are roles to assign
88a2c2d
@eokoneyo
integrate security packages
4b76e01
@eokoneyo
add tests for provisioning privilege API client
9cbf1ec
@eokoneyo
even more UI improvements
8f2f38d
@eokoneyo
refactor trigger for flyout and integrate it with bulk actions
1bc6528
@eokoneyo
make accomodation for edit existing record
63035a7
@eokoneyo
integrate API to update roles, leverage this to update existing space…
9541fc4 
… privilege
@eokoneyo
add logic to handle removing roles from space
ee5e218
@eokoneyo
refactor implementation to provide visual feedback on UI actions
c13613e
@eokoneyo
fix logic for excluding roles already ppart of space
a50eade
@eokoneyo
fix logic with selectable items
ad1e526
@eokoneyo
add implementation for assigning custom roles privileges
f51800b
@tsullivan tsullivan marked this pull request as ready for review August 28, 2024 15:04
@tsullivan tsullivan merged commit ccd34f3 into tsullivan:roles/details/spaces-modal Aug 28, 2024
@eokoneyo eokoneyo mentioned this pull request Aug 28, 2024
Closed
@eokoneyo eokoneyo deleted the assign-roles-to-space branch August 28, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eokoneyo @tsullivan @kibanamachine