readmeの更新 #100
Merged
readmeの更新 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
- **ウォークスルー**: README.mdの内容が更新され、プロジェクトの概要と機能リストが修正されました。また、GitHub Actionsのワークフローに手動トリガー機能が追加され、ブランチ名からissue番号を抽出するロジックが改善されました。
- **変更点**:
| ファイル | 要約 |
| --- | --- |
| README.md | プロジェクトの概要と機能リストの修正、翻訳機能やインターフェースに関する説明の簡略化、新たな脚注や解説の追加。 |
| .github/workflows/link-pr-to-issue.yml | `ISSUE_NUMBER`の抽出失敗時のエラー無視、`workflow_dispatch`イベントの追加、手動トリガー時のプルリクエスト番号入力機能、ブランチ名からissue番号を抽出するロジックの更新。 |Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (1)
- README.md (1)
Files skipped from review due to trivial changes (1)
- README.md
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
There was a problem hiding this comment.
Files selected (1)
- .github/workflows/link-pr-to-issue.yml (1)
Review comments generated (1)
- Review: 1
- LGTM: 0
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
| @@ -12,7 +12,7 @@ jobs: | |||
| id: extract-issue | |||
| run: | | |||
| BRANCH_NAME="${{ github.head_ref }}" | |||
| ISSUE_NUMBER=$(echo $BRANCH_NAME | grep -oP 'issue-\K\d+') | |||
| ISSUE_NUMBER=$(echo $BRANCH_NAME | grep -oP 'issue-\K\d+' || true) | |||
There was a problem hiding this comment.
grep -oPは、-Pオプションを使用してPerl互換の正規表現を有効にしていますが、これはすべての環境でサポートされているわけではありません。より広くサポートされている方法として、grep -Eを使用することをお勧めします。
- ISSUE_NUMBER=$(echo $BRANCH_NAME | grep -oP 'issue-\K\d+' || true)
+ ISSUE_NUMBER=$(echo $BRANCH_NAME | grep -Eo 'issue-[0-9]+' | cut -d'-' -f2 || true)
There was a problem hiding this comment.
Files selected (1)
- .github/workflows/link-pr-to-issue.yml (2)
Review comments generated (2)
- Review: 1
- LGTM: 1
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
Comment on lines
+19
to
+25
| if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then | ||
| PR_NUMBER="${{ github.event.inputs.pr_number }}" | ||
| BRANCH_NAME=$(gh pr view $PR_NUMBER --json headRefName -q .headRefName) | ||
| else | ||
| BRANCH_NAME="${{ github.head_ref }}" | ||
| fi | ||
| ISSUE_NUMBER=$(echo $BRANCH_NAME | grep -oP 'issue-\K\d+' || true) |
There was a problem hiding this comment.
gh pr viewコマンドの実行に失敗した場合、スクリプトがエラーで停止する可能性があります。これを防ぐために、エラーハンドリングを追加することをお勧めします。
+ set -e
if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
PR_NUMBER="${{ github.event.inputs.pr_number }}"
+ BRANCH_NAME=$(gh pr view $PR_NUMBER --json headRefName -q .headRefName || echo "")
else
BRANCH_NAME="${{ github.head_ref }}"
fi
ISSUE_NUMBER=$(echo $BRANCH_NAME | grep -oP 'issue-\K\d+' || true)
There was a problem hiding this comment.
Files selected (1)
- .github/workflows/link-pr-to-issue.yml (1)
Review comments generated (2)
- Review: 1
- LGTM: 1
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
Comment on lines
+18
to
+26
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| BRANCH_NAME="${{ github.head_ref }}" | ||
| ISSUE_NUMBER=$(echo $BRANCH_NAME | grep -oP 'issue-\K\d+') | ||
| if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then | ||
| PR_NUMBER="${{ github.event.inputs.pr_number }}" | ||
| BRANCH_NAME=$(gh pr view $PR_NUMBER --json headRefName -q .headRefName) | ||
| else | ||
| BRANCH_NAME="${{ github.head_ref }}" | ||
| fi |
There was a problem hiding this comment.
インデントが不揃いです。envとrunのインデントを修正してください。
- env:
+ env:
- run: |
+ run: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit