Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ttizze/bug issue 96 #108

Merged
merged 4 commits into from
Jul 27, 2024
Merged

Ttizze/bug issue 96 #108

merged 4 commits into from
Jul 27, 2024

Conversation

ttizze
Copy link
Owner

@ttizze ttizze commented Jul 27, 2024

Closes #96

Summary by CodeRabbit

### リリースノート

#### Refactor
- `autolabeler`の設定で、ブランチ名に基づくラベル付けルールが変更されました。
- GitHub Actionsのジョブ内でラベルの存在をチェックするロジックを簡素化しました。
- ラベルとブランチプレフィックスのマッピングを定義するために`LABEL_PREFIX_MAP`連想配列を追加しました。

#### Style
- `<h4>`タグを`<p>`タグに変更しました。

#### Refactor
- `targetLanguage`プロパティを削除し、関連する依存関係と状態変数を更新しました。

Copy link

This PR is linked to issue #96

Copy link

github-actions bot commented Jul 27, 2024

Image description CodeRabbit

### ウォークスルー
この変更では、GitHub Actionsのワークフローとラベル付けロジックの改善、Reactコンポーネントのリファクタリング、およびHTMLタグの修正が行われました。これにより、コードの保守性と一貫性が向上しています。

### 変更点
| ファイル | 要約 |
| --- | --- |
| .github/release-drafter.yml | `enhancement`ラベルのブランチパターンを`/enhance[/-].+/`に変更 |
| .github/workflows/auto-comment-on-unlabeled-issue.yml | ラベルチェックロジックの簡素化と不要な変数・コメントの削除 |
| .github/workflows/create-branch-on-issue-assign.yml | `LABEL_PREFIX_MAP`連想配列の追加とブランチ名生成ロジックの更新 |
| web/app/routes/reader.$encodedUrl/components/AddAndVoteTranslations.tsx | `<h4>`タグを`<p>`タグに変更 |
| web/app/routes/reader.$encodedUrl/components/ContentWithTranslations.tsx, web/app/routes/reader.$encodedUrl/components/Translation.tsx, web/app/routes/reader.$encodedUrl/components/TranslationItem.tsx | `targetLanguage`プロパティの削除、状態変数とマウスイベントハンドリングロジックの更新、CSSクラスの削除 |

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between d5cc2b5 and 70d6871 commits.
Files selected (7)
  • .github/release-drafter.yml (1)
  • .github/workflows/auto-comment-on-unlabeled-issue.yml (1)
  • .github/workflows/create-branch-on-issue-assign.yml (2)
  • web/app/routes/reader.$encodedUrl/components/AddAndVoteTranslations.tsx (2)
  • web/app/routes/reader.$encodedUrl/components/ContentWithTranslations.tsx (3)
  • web/app/routes/reader.$encodedUrl/components/Translation.tsx (3)
  • web/app/routes/reader.$encodedUrl/components/TranslationItem.tsx (1)
Files skipped from review due to trivial changes (2)
  • web/app/routes/reader.$encodedUrl/components/AddAndVoteTranslations.tsx
  • web/app/routes/reader.$encodedUrl/components/TranslationItem.tsx
Review comments generated (10)
  • Review: 0
  • LGTM: 10

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@ttizze ttizze added the bug Something isn't working as expected label Jul 27, 2024
@ttizze ttizze merged commit 9c08c48 into main Jul 27, 2024
1 check passed
@ttizze ttizze deleted the ttizze/bug-issue-96 branch July 27, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

翻訳コンポーネントの上の線が消えている
1 participant