Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f #110

Merged
merged 1 commit into from
Jul 27, 2024
Merged

f #110

merged 1 commit into from
Jul 27, 2024

Conversation

ttizze
Copy link
Owner

@ttizze ttizze commented Jul 27, 2024

Summary by CodeRabbit

### Chore
- GitHub Actions ワークフローの名前とジョブ名を変更
- `actions/checkout` のバージョンを `v3` から `v4` に更新
- `biome check --write` コマンドを `biome check` に変更
- `git-auto-commit-action` を削除
- `contents` パーミッションを `write` から `read` に変更

@github-actions github-actions bot added the bug Something isn't working as expected label Jul 27, 2024
Copy link

github-actions bot commented Jul 27, 2024

Image description CodeRabbit

- **ウォークスルー**: この変更は、GitHub Actions ワークフローの名前とジョブ名の更新、依存するアクションのバージョンアップ、コマンドの修正、および不要なアクションの削除を行い、セキュリティパーミッションを調整しています。

- **変更点**:
  | ファイル | 要約 |
  | --- | --- |
  | .github/workflows/biome.yaml | GitHub Actions ワークフローの名前とジョブ名を変更し、`actions/checkout` のバージョンを `v3` から `v4` に更新。`biome check --write` コマンドを `biome check` に変更し、`git-auto-commit-action` を削除。`contents` パーミッションを `write` から `read` に変更。 |

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between be4cdc2 and d49c865 commits.
Files selected (1)
  • .github/workflows/biome.yaml (2)
Review comments generated (2)
  • Review: 1
  • LGTM: 1

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Comment on lines +10 to +26
biome-check-for-web:
runs-on: ubuntu-latest
permissions:
contents: write
contents: read
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: "20"
- name: Install Bun
run: npm install -g bun
- name: Install dependencies
run: cd web && bun i
- name: Run Biome check and fix
- name: Run Biome check
run: |
cd web
bunx @biomejs/biome check --write .
- name: Commit changes
uses: stefanzweifel/git-auto-commit-action@v4
with:
file_pattern: "web/**/*"
branch: ${{ github.head_ref }}
bunx @biomejs/biome check .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

actions/checkout のバージョンを v4 に更新する際には、互換性の問題がないか確認してください。また、biome check コマンドに変更したことで、修正が自動的に行われなくなります。これにより、手動で修正を行う必要が生じる可能性がありますので注意が必要です。

-  biome-check-and-fix-for-web:
+  biome-check-for-web:

@ttizze ttizze merged commit 9c0586e into main Jul 27, 2024
6 checks passed
@ttizze ttizze deleted the fix/biomeaction branch July 27, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant