Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update workflows to use workflow_dispatch event #115

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

ttizze
Copy link
Owner

@ttizze ttizze commented Jul 28, 2024

Closes #105

Summary by CodeRabbit

リリースノート

変更内容

  • Chore: GitHub Actionsのワークフローイベントをpull_requestおよびpushからworkflow_dispatchに変更し、手動でワークフローを実行できるようにしました。
  • Chore: 不要なブランチ指定とパーミッション設定を削除しました。

Copy link

This PR is linked to issue #105

@ttizze ttizze merged commit 05d3651 into main Jul 28, 2024
4 checks passed
Copy link

github-actions bot commented Jul 28, 2024

Image description CodeRabbit

### ウォークスルー

この変更では、GitHub Actionsのワークフローイベントを`pull_request`および`push`から`workflow_dispatch`に変更し、手動でワークフローを実行できるようにしています。また、不要な設定が削除されています。

### 変更点

| ファイル | 要約 |
| --- | --- |
| .github/workflows/create-release-note.yaml, .github/workflows/sync-labels.yaml | GitHub Actionsのワークフローイベントを`workflow_dispatch`に変更し、手動でワークフローを実行可能に。不要な設定も削除。 |

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

@ttizze ttizze deleted the ttizze/enhance-issue-105 branch July 28, 2024 04:03
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between f9fc79a and edae218 commits.
Files selected (2)
  • .github/workflows/create-release-note.yaml (1)
  • .github/workflows/sync-labels.yaml (1)
Review comments generated (4)
  • Review: 2
  • LGTM: 2

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@@ -1,8 +1,6 @@
name: Sync Labels
on:
workflow_dispatch:
push:
branches: [main]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

不要な空行が含まれています。削除することをお勧めします。

-  
+

Comment on lines 6 to +7
- closed
branches:
- main

permissions:
contents: read
workflow_dispatch:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

pull_requestイベントのtypesclosedのみが残っているため、他のイベント(opened, reopened, synchronize)が削除されています。これにより、プルリクエストが閉じられたときのみワークフローがトリガーされるようになりますが、意図的な変更か確認が必要です。

また、branchesセクションが削除されていますが、特定のブランチでのみワークフローを実行する必要がある場合は、この設定を保持するべきです。

 on:
   pull_request:
     types:
+      - opened
+      - reopened
+      - synchronize
       - closed
+    branches:
+      - main
   workflow_dispatch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

github actionsの適切な設定を考える
1 participant