Test commit #75
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Biome Check and Fix for Web | ||
|
|
||
| on: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| biome-check-and-fix-for-web: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '20' | ||
| - name: Install Bun | ||
| run: npm install -g bun | ||
| - name: Install dependencies | ||
| run: cd web && bun i | ||
|
There was a problem hiding this comment.
依存関係のインストールに失敗した場合のエラーハンドリングが不足しています。 - run: cd web && bun i
+ run: |
+ cd web
+ if ! bun i; then
+ echo "Dependency installation failed"
+ exit 1
+ fi |
||
| - name: Run Biome check and fix | ||
| run: | | ||
| cd web | ||
| bunx @biomejs/biome check --write . | ||
|
There was a problem hiding this comment.
Biome チェックと修正に失敗した場合のエラーハンドリングが不足しています。 - bunx @biomejs/biome check --write .
+ if ! bunx @biomejs/biome check --write .; then
+ echo "Biome check and fix failed"
+ exit 1
+ fi |
||
| - name: Commit changes | ||
| uses: stefanzweifel/git-auto-commit-action@v4 | ||
| with: | ||
| commit_message: "style: write Biome fixes" | ||
| file_pattern: 'web/**/*' | ||
|
There was a problem hiding this comment.
ファイルパターンの指定が広すぎます。特定のファイルタイプに絞ることで、不要なコミットを防ぐことができます。 - file_pattern: 'web/**/*'
+ file_pattern: 'web/**/*.js' |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm install -g bunはセキュリティ上のリスクがあるため、特定のバージョンをインストールすることをお勧めします。