Add PBXTarget Related Properties and Diff Fixes #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The productInstallPath is a PBXNativeTarget-specific property. Add support for reading and writing the property so it’s not lost when round-tripping projects that use it with xcproj. It’s not clear to me if this is still accessible in the Xcode UI or if it’s only a carryover from legacy projects.
While roundtripping many projects through xcproj, I discovered some PBXTargetDependency objects have a name property. Implement support for reading and writing it so it’s not lost when proejcts are edited by xcproj.
Xcode doesn’t support build rules for PBXAggregateTarget. Although the UI shows the Build Rules tab, they’re never written to the file. Update xcproj to follow the same behavior to eliminate diffs.
pepicrft
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
Add properties
PBXTargetand friends to support additional optional properties in the Xcode project file and eliminate some diff noise as well.Solution 📦
Add a
productInstallPathtoPBXNativeTargetand anameproperty toPBXTargetDependency, which was discovered while analyzing the 218 in our code base. Fix diff noise when writingPBXAggregateTarget.Implementation 👩💻👨💻
buildRulesforPBXAggregateTargeteven if the user adds a custom ruleThis change is