Special Quote Cases for Commented Strings #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantkelley
force-pushed
the
commentedstring-quotes
branch
from
9723280
to
c971a21
Compare
yonaskolb
reviewed
Mar 8, 2018
Sources/xcproj/CommentedString.swift
Outdated
| if !escaped.isQuoted && escaped.rangeOfCharacter(from: CommentedString.invalidCharacters) != nil { | ||
| if !escaped.isQuoted && | ||
| (escaped.rangeOfCharacter(from: CommentedString.invalidCharacters) != nil || | ||
| escaped.range(of: "___") != nil || |
There was a problem hiding this comment.
How about we add a CommentedString.invalidStrings
briantkelley
force-pushed
the
commentedstring-quotes
branch
2 times, most recently
from
b3f3bd7
to
ad70abd
Compare
|
Friendly ping |
pepicrft
approved these changes
Mar 15, 2018
Xcode has a weird rule that causes it to quote strings with a triple underscore. It also quotes strings that have a double forward slash. Add support for those in order to improve eliminate diffs.
briantkelley
force-pushed
the
commentedstring-quotes
branch
from
ad70abd
to
01e15e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
Xcode adds quotes around strings in the project file if they contain a triple underscore or double forward slash. Update xcproj to do the same.
Solution 📦
Check for occurrences of the special sequences and add quotes if they occur.
Implementation 👩💻👨💻
This change is