Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added location to TestableReference #654

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

KrisRJack
Copy link
Contributor

@KrisRJack KrisRJack commented Nov 27, 2021

Short description 📝

Added LocationScenarioReference as an option for Test Targets. Images below show how these options are applied in both Xcode and .xcsheme file.

These changes are necessary for this issue in XcodeGen.

143057737-d4c2eead-6dfb-4215-a133-e1772d389712

143057759-55cf212c-76d0-4689-af56-a1e1e31598b8

@KrisRJack
Copy link
Contributor Author

Hey All! Just wondering if there is anything more that I need do here on my end to help move this PR forward. This would be an awesome addition that our team could really use. (cc. @pepicrft)

@pepicrft
Copy link
Contributor

pepicrft commented Dec 3, 2021

Sorry for the late review @KrisRJack. Changes look good so as soon as CI is happy I'll go ahead, merge, and release a new version

@pepicrft
Copy link
Contributor

pepicrft commented Dec 3, 2021

@all-contributors add @KrisRJack for code

@allcontributors
Copy link
Contributor

@pepicrft

I've put up a pull request to add @KrisRJack! 🎉

@KrisRJack
Copy link
Contributor Author

Awesome 🎉! No worries at all and thank you so much @pepicrft!

@pepicrft pepicrft merged commit 1e4016a into tuist:main Dec 3, 2021
@KrisRJack KrisRJack deleted the location branch December 3, 2021 14:11
@pepicrft
Copy link
Contributor

pepicrft commented Dec 3, 2021

@KrisRJack here is the release with your changes. Again, thanks for your contribution 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants