-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for initializing a PBXProj via a direct path #682
Allow for initializing a PBXProj via a direct path #682
Conversation
Allows for a pbxproj path to be initied with a direct path, also moves some related code to the PBXProj class
Codecov Report
@@ Coverage Diff @@
## main #682 +/- ##
==========================================
+ Coverage 84.81% 84.84% +0.03%
==========================================
Files 157 157
Lines 9026 9044 +18
==========================================
+ Hits 7655 7673 +18
Misses 1371 1371
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why not make this reusable but would wait for @kwridan review before merging 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting this @maxwellE !
I recall needing a public accessor to PBXProj
a while back when I prototyped bloomberg/xcdiff#25 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @maxwellE
Short description 📝
Allows for a pbxproj path to be initiated with a direct path, also
moves some related code to the PBXProj class
Solution 📦
Simply moves around the code that already exists and opens some ACLs to allow callers of the library to use this code
Implementation 👩💻👨💻
N/A