Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for initializing a PBXProj via a direct path #682

Merged
merged 4 commits into from
May 8, 2022

Conversation

maxwellE
Copy link
Contributor

Short description 📝

Allows for a pbxproj path to be initiated with a direct path, also
moves some related code to the PBXProj class

Solution 📦

Simply moves around the code that already exists and opens some ACLs to allow callers of the library to use this code

Implementation 👩‍💻👨‍💻

N/A

Allows for a pbxproj path to be initied with a direct path, also
moves some related code to the PBXProj class
@maxwellE maxwellE changed the title Allow for initing a PBXProj via a direct path Allow for initalizing a PBXProj via a direct path Apr 29, 2022
@maxwellE maxwellE changed the title Allow for initalizing a PBXProj via a direct path Allow for initializing a PBXProj via a direct path Apr 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #682 (958b01d) into main (92e43ed) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
+ Coverage   84.81%   84.84%   +0.03%     
==========================================
  Files         157      157              
  Lines        9026     9044      +18     
==========================================
+ Hits         7655     7673      +18     
  Misses       1371     1371              
Impacted Files Coverage Δ
Sources/XcodeProj/Objects/Project/PBXProj.swift 78.83% <100.00%> (+7.54%) ⬆️
Sources/XcodeProj/Project/XcodeProj.swift 28.98% <100.00%> (-14.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e43ed...958b01d. Read the comment docs.

@fortmarek fortmarek requested a review from kwridan May 2, 2022 16:59
Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why not make this reusable but would wait for @kwridan review before merging 👍

Sources/XcodeProj/Objects/Project/PBXProj.swift Outdated Show resolved Hide resolved
Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this @maxwellE !

I recall needing a public accessor to PBXProj a while back when I prototyped bloomberg/xcdiff#25 😅

Sources/XcodeProj/Objects/Project/PBXProj.swift Outdated Show resolved Hide resolved
@maxwellE maxwellE requested a review from kwridan May 4, 2022 20:02
Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @maxwellE

Sources/XcodeProj/Objects/Project/PBXProj.swift Outdated Show resolved Hide resolved
Sources/XcodeProj/Objects/Project/PBXProj.swift Outdated Show resolved Hide resolved
@kwridan kwridan merged commit 65ca255 into tuist:main May 8, 2022
@maxwellE maxwellE deleted the maxwell/allow_pbxproj_init_via_path branch May 9, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants