Ensure correct LaunchAction scheme order
#686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logic and tests to ensure that the XML ordering for `LaunchAction` matches what xcode expects
Codecov Report
@@ Coverage Diff @@
## main #686 +/- ##
==========================================
+ Coverage 84.84% 84.89% +0.05%
==========================================
Files 157 157
Lines 9044 9076 +32
==========================================
+ Hits 7673 7705 +32
Misses 1371 1371
Continue to review full report at Codecov.
|
kwridan
approved these changes
Jun 2, 2022
|
@pepicrft Can I get a review on this? Thanks |
danieleformichelli
approved these changes
Jun 10, 2022
Co-authored-by: Daniele Formichelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
Adds logic and tests to ensure that the XML
ordering for
LaunchActionschemes matches whatxcode expects