-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ordering of Scheme toplevel attrs #698
Fix ordering of Scheme toplevel attrs #698
Conversation
Fix for incorrect ordering of `Scheme` attrs when using `wasCreatedForAppExtension` value
Codecov Report
@@ Coverage Diff @@
## main #698 +/- ##
==========================================
+ Coverage 84.93% 84.96% +0.03%
==========================================
Files 157 157
Lines 9127 9147 +20
==========================================
+ Hits 7752 7772 +20
Misses 1375 1375
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maxwellE
) | ||
} | ||
|
||
func test_Scheme_attributes_sorted_when_original_unsorted() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: this test may be redundant, the order in which dictionary elements are specified to my knowledge is opaque to the underlying types, the dictionaries are equal between this test and test_Scheme_attributes_sorted_when_original_sorted
, as such only one of those tests will suffice.
An interesting test could be the following (but may be overkill for this)
- Start with an unsorted raw XML (string) scheme
- Deserialize it (read it vis
XCScheme
) - Serialize it back to XML
- Verify the correct sort order
@maxwellE thanks for the PR. I've merged some of them and looks like that created a conflict here. Once that's resolved we can get this merged! |
Fix for incorrect ordering of
Scheme
attrs whenusing
wasCreatedForAppExtension
value