Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEAD_CODE_STRIPPING default project setting #706

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

kwridan
Copy link
Collaborator

@kwridan kwridan commented Jul 10, 2022

Relates to: tuist/tuist#4531

Short description 📝

  • As of Xcode 14, DEAD_CODE_STRIPPING is now a recommended setting for macOS or iOS with catalyst projects and targets

Solution 📦

  • Add DEAD_CODE_STRIPPING as a default project setting
  • iOS already had DEAD_CODE_STRIPPING enabled as a default in prior Xcode versions, so explicitly setting shouldn't cause a change in behaviour

- As of Xcode 14, `DEAD_CODE_STRIPPING` is now a recommended setting for macOS or iOS with catalyst projects and targets
- iOS already had `DEAD_CODE_STRIPPING` enabled as a default in prior Xcode versions, so explicitly setting shouldn't cause a change in behaviour

tuist/tuist#4531
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #706 (947c039) into main (d8f4b06) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
- Coverage   84.80%   84.79%   -0.01%     
==========================================
  Files         157      157              
  Lines        9172     9173       +1     
==========================================
  Hits         7778     7778              
- Misses       1394     1395       +1     
Impacted Files Coverage Δ
...ources/XcodeProj/Utils/BuildSettingsProvider.swift 53.76% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f4b06...947c039. Read the comment docs.

Copy link
Collaborator

@luispadron luispadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kwridan

@fortmarek fortmarek merged commit 490057a into main Jul 13, 2022
@fortmarek fortmarek deleted the update/xcode14-recommended-settings branch July 13, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants