Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellToInvoke to XCScheme.ExecutionAction #721

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Add shellToInvoke to XCScheme.ExecutionAction #721

merged 1 commit into from
Sep 7, 2022

Conversation

CrazyFanFan
Copy link
Contributor

Short description 📝

If a post_actions specifies shellToInvoke, this field will be lost after rewriting with XCScheme;

Solution 📦

Add property shellToInvoke to XCScheme.ExecutionAction to fix shellToInvoke missing after editing XCProject.

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this @CrazyFanFan

@kwridan
Copy link
Collaborator

kwridan commented Sep 7, 2022

@all-contributors add @CrazyFanFan for code

@allcontributors
Copy link
Contributor

@kwridan

I've put up a pull request to add @CrazyFanFan! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #721 (9b77208) into main (c36d3a8) will increase coverage by 0.00%.
The diff coverage is 84.61%.

@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   84.90%   84.90%           
=======================================
  Files         158      158           
  Lines        9241     9249    +8     
=======================================
+ Hits         7846     7853    +7     
- Misses       1395     1396    +1     
Impacted Files Coverage Δ
...es/XcodeProj/Scheme/XCScheme+ExecutionAction.swift 72.72% <81.81%> (+2.35%) ⬆️
Tests/XcodeProjTests/Scheme/XCSchemeTests.swift 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@luispadron luispadron merged commit 1259fdc into tuist:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants